Mercenary #1448
Mercenary #1448
Conversation
|
can you run the code through eslint |
|
Ran esLint - it didn't detect any issues other than not being able to find certain symbols (like Config/Town/Misc/me/print()/etc). |
|
well there seems to be lots of white space / new line issues in mercenary.js are you using the eslint settings for kolbot provided in the readme or some random one? |
|
Sorry, you're right, I missed the eslint configs from the readme. I re-ran and fixed them. |
|
Checked in a fix but somehow other stuff got rolled up into the push. I'll have to fix it. |
|
Removed commits that didn't belong in this PR. |
| throw new Error("Mercenary.hire: args.mercType is required"); | ||
| } | ||
|
|
||
| if (args.mercType < 1 || args.mercType === 4 || args.mercType > 5) { |
There was a problem hiding this comment.
I've seen this check done before, maybe change mercType to a get/set that auto validates the input so you don't need to sanitize it every time
There was a problem hiding this comment.
I'm not sure that I understand what you mean by this or how you propose that it would be used.
|
|
||
| switch (mercType) { | ||
| case 1: | ||
|
|
| } | ||
|
|
||
| break; | ||
|
|
There was a problem hiding this comment.
don't need newlines after breaks
| if (args.variant === v) { | ||
| break; | ||
| } | ||
|
|
| } | ||
|
|
||
| me.cancel(); | ||
|
|
| print("No mercs available"); | ||
|
|
||
| me.cancel(); | ||
|
|
| revive: function () { | ||
| if (!this.needMerc()) { | ||
| print("I don't need to revive my merc"); | ||
|
|
| while (getTickCount() - tick < 2000) { | ||
| if (this.getMerc()) { | ||
| delay(Math.max(750, me.ping * 2)); | ||
|
|
| print("Unloading merc equipment"); | ||
| var cursorItem; | ||
|
|
||
| // ok this is a bit stupid |
There was a problem hiding this comment.
can you turn this into a loop that goes 4, 3, 1 since the code just repeats?
|
|
||
| delay(1000 + me.ping * 2); | ||
|
|
||
| removeEventListener("gamepacket", this._gamePacket); |
|
|
||
| mercPacket: function (bytes) { | ||
| if (bytes[0] !== 0x4e) { | ||
| return; |
There was a problem hiding this comment.
is there any way to get available mercs without using packets?
possibly by parsing the list?
Highlights:
To specify which merc to use, modify config as follows:
Config.UseMerc={mercType: 1, variant: 11};
mercType is set to the act# - for example, 1 for act 1 rogue merc, 5 for act 5 barb
variant is set to the skill (see sdk/skills.txt) that you want your merc to have - in this case 11 for cold arrow.
Variant can be omitted if you don't care which skill the merc has.
Notes: